[Webkit-unassigned] [Bug 35087] New port: EFL; adding files to WebCore/*/efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35087





--- Comment #16 from Leandro Pereira <leandro at profusion.mobi>  2010-02-19 11:20:53 PST ---
(In reply to comment #14)
> class Cursors {
> protected:
>      Cursors()
>          : PointerCursor("cursor/pointer"),
> ...
> The comma should be at the beginning of the next line rather than the end of
> the current

check-webkit-style didn't warn me about this.

> 
> It looks like KeyboardCodes, KeyboardCodeMIMETypeRegistry are also candidates
> for refactoring to allow multiple ports to share code, which it is probably
> worth looking at before landing these patches, as otherwise the unshared code
> is unlikely to ever become shared.
> 

I've removed KeyboardCodes, as it happened to be almost identical to the shared
one.

>
> RenderTheme implementation has a lot of incorrect style usage, ( for a call
> always goes after the function, not on the next line.
> 

check-webkit-style didn't warn me about this too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.