[Webkit-unassigned] [Bug 50115] Please implement async=false for dynamic script loading (REGRESSION: LABjs is broken)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 3 12:18:47 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=50115





--- Comment #25 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-03 12:18:46 PST ---
(In reply to comment #24)
> How about:
> for (size_t i = 0; ; ++i) {
>     if (i >= m_scriptsToExecuteInOrder.size() || !m_scriptsToExecuteInOrder[i].cachedScript->isLoaded()) {
>         m_scriptsToExecuteInOrder.remove(0, i);
>         break;
>     }
>     scripts.append(m_scriptsToExecuteInOrder[i]);
> }

Oops, this doesn't quite work.  It needs to be:
for (size_t i = 0; ; ++i) {
    if (i >= m_scriptsToExecuteInOrder.size() || !m_scriptsToExecuteInOrder[i].cachedScript->isLoaded()) {
        if (i)
            m_scriptsToExecuteInOrder.remove(0, i);
        break;
    }
    scripts.append(m_scriptsToExecuteInOrder[i]);
}

Your version might be better after all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list