[Webkit-unassigned] [Bug 50115] Please implement async=false for dynamic script loading (REGRESSION: LABjs is broken)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50115





--- Comment #26 from Tony Gentilcore <tonyg at chromium.org>  2010-12-04 10:09:43 PST ---
(From update of attachment 75523)
View in context: https://bugs.webkit.org/attachment.cgi?id=75523&action=review

> LayoutTests/fast/dom/HTMLScriptElement/resources/big.js:3
> +    About 16KB to make this resource load slowly.

I'm not sure if this will reliably check your condition (although it won't be flaky). Did you consider making this an http test with a php/cgi resource that sleeps before returning? That is what some other script ordering tests do.

> LayoutTests/fast/dom/HTMLScriptElement/script-async-attr.html:17
> +<script id="s7" async></script>

We should also test <script id="s8" async="false"></script>

> WebCore/dom/ScriptRunner.cpp:1
> +/*

It is really difficult to review a rename with changes to the renamed file in the same patch. Is it too much trouble to ask to separate them?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.