[Webkit-unassigned] [Bug 50115] Please implement async=false for dynamic script loading (REGRESSION: LABjs is broken)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50115





--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org>  2010-12-03 12:14:51 PST ---
(From update of attachment 75523)
View in context: https://bugs.webkit.org/attachment.cgi?id=75523&action=review

> WebCore/dom/ScriptRunner.cpp:101
> +    size_t numInOrderScriptsToExecute = 0;
> +    for (; numInOrderScriptsToExecute < m_scriptsToExecuteInOrder.size() && m_scriptsToExecuteInOrder[numInOrderScriptsToExecute].cachedScript->isLoaded(); ++numInOrderScriptsToExecute)
> +        scripts.append(m_scriptsToExecuteInOrder[numInOrderScriptsToExecute]);
> +    if (numInOrderScriptsToExecute)
> +        m_scriptsToExecuteInOrder.remove(0, numInOrderScriptsToExecute);

How about:
for (size_t i = 0; ; ++i) {
    if (i >= m_scriptsToExecuteInOrder.size() || !m_scriptsToExecuteInOrder[i].cachedScript->isLoaded()) {
        m_scriptsToExecuteInOrder.remove(0, i);
        break;
    }
    scripts.append(m_scriptsToExecuteInOrder[i]);
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.