[Webkit-unassigned] [Bug 50299] webkit-patch needs land-no-bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50299





--- Comment #10 from Dirk Pranke <dpranke at chromium.org>  2010-12-01 16:09:00 PST ---
(In reply to comment #9)
> (In reply to comment #6)
> > > Is there a benefit of land-cowboy not running check-style?
> > 
> > It's faster and it doesn't complain when you make style errors.  Cowboys don't care about style errors.
> 
> Why do we want the tool to make committing style errors easy? I don't support cowboys apparently.
> 

+1

> 
> (In reply to comment #7)
> > Isn't that just 'webkit-patch land' ?
> 
> webkit-patch land:
>         steps.EnsureBuildersAreGreen,
>         steps.UpdateChangeLogsWithReviewer,
>         steps.ValidateReviewer,
>         steps.Build,
>         steps.RunTests,
>         steps.Commit,
>         steps.CloseBugForLandDiff,
> 
> webkit-patch land-cowboy:
>         steps.PrepareChangeLog,
>         steps.EditChangeLog,
>         steps.ConfirmDiff,
>         steps.Build,
>         steps.RunTests,
>         steps.Commit,
> 
> proposed webkit-patch land-no-bug:
>         steps.PrepareChangeLog,
>         steps.EditChangeLog,
>         steps.CheckStyle,
>         steps.ConfirmDiff,
>         steps.Build,
>         steps.RunTests,
>         steps.Commit,

It's not clear to me why webkit-patch land doesn't do the missing steps, since these steps tend to be idempotent. It would seem to me like if you didn't want to step through the prompts, then that's what --non-interactive should be for.

Also, when I do webkit-patch land, it never does a build or runs tests. I don't know offhand what to make of that discrepancy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.