[Webkit-unassigned] [Bug 50299] webkit-patch needs land-no-bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50299


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|webkit-patch land-cowboy    |webkit-patch needs
                   |should run the CheckStyle   |land-no-bug
                   |step                        |
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |




--- Comment #9 from Ojan Vafai <ojan at chromium.org>  2010-12-01 15:59:34 PST ---
(In reply to comment #6)
> > Is there a benefit of land-cowboy not running check-style?
> 
> It's faster and it doesn't complain when you make style errors.  Cowboys don't care about style errors.

Why do we want the tool to make committing style errors easy? I don't support cowboys apparently.


(In reply to comment #7)
> Isn't that just 'webkit-patch land' ?

webkit-patch land:
        steps.EnsureBuildersAreGreen,
        steps.UpdateChangeLogsWithReviewer,
        steps.ValidateReviewer,
        steps.Build,
        steps.RunTests,
        steps.Commit,
        steps.CloseBugForLandDiff,

webkit-patch land-cowboy:
        steps.PrepareChangeLog,
        steps.EditChangeLog,
        steps.ConfirmDiff,
        steps.Build,
        steps.RunTests,
        steps.Commit,

proposed webkit-patch land-no-bug:
        steps.PrepareChangeLog,
        steps.EditChangeLog,
        steps.CheckStyle,
        steps.ConfirmDiff,
        steps.Build,
        steps.RunTests,
        steps.Commit,

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.