[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #11 from Philippe Normand <pnormand at igalia.com>  2010-08-25 01:13:27 PST ---
(In reply to comment #10)

> I wonder how to use PlatformWidget directly. In order to use the PlatformformWidget directly, I think we need to modify code as below,
> 
>  48 #if PLATFORM(GTK)
>  49         PlatformWindowType* window() const { return m_window; }
>  50 #elif PLATFORM(EFL)
>  51         PlatformWidget* window() const { return m_window; }
>  52 #endif
> 
> 

No, it would be best to make the GTK port use PlatformWidget as well, it will all be more coherent and readable.

> I modify above code as below,
> 
>  31 #elif PLATFORM(EFL)
>  32 #if ENABLE(GLIB_SUPPORT)
>  33 #include <glib.h>
>  34 #endif
>  35 #include "Widget.h"
>  36 typedef PlatformWidget PlatformWindowType;
>  37 #endif
> 
> Is this ok ?

No. I thought I was clear, but it seems not :)
glib.h can safely be included *outside* any #ifs like this:

#include <glib.h>

If you make use of PlatformWidget no #if at all should be needed in this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.