[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #12 from Philippe Normand <pnormand at igalia.com>  2010-08-25 01:27:24 PST ---
(In reply to comment #11)
> 
> > I modify above code as below,
> > 
> >  31 #elif PLATFORM(EFL)
> >  32 #if ENABLE(GLIB_SUPPORT)
> >  33 #include <glib.h>
> >  34 #endif
> >  35 #include "Widget.h"
> >  36 typedef PlatformWidget PlatformWindowType;
> >  37 #endif
> > 
> > Is this ok ?
> 

Well I understand your port doesn't have a hard dependency on GLib, so yeah you need guards, maybe like:

#if PLATFORM(GTK) || ENABLE(GLIB_SUPPORT)
#include <glib.h>
#endif

?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.