[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-08-25 01:03:31 PST ---
(In reply to comment #9)
> (From update of attachment 65381 [details])
> >--- a/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
> >+++ b/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
> >@@ -28,6 +28,15 @@
> > #if PLATFORM(GTK)
> > #include <gtk/gtk.h>
> > typedef GtkWidget PlatformWindowType;
> >+#elif PLATFORM(EFL)
> >+#include "Widget.h"
> >+typedef PlatformWidget PlatformWindowType;
> >+#endif
> >+
> 
> Oh nice I didn't know about Widget.h
> So we duplicated efforts here. I think it'd make sense to remove PlatformWindowType and use PlatformWidget directly.
> 

I wonder how to use PlatformWidget directly. In order to use the PlatformformWidget directly, I think we need to modify code as below,

 48 #if PLATFORM(GTK)
 49         PlatformWindowType* window() const { return m_window; }
 50 #elif PLATFORM(EFL)
 51         PlatformWidget* window() const { return m_window; }
 52 #endif


> >+#if PLATFORM(EFL)
> >+#if ENABLE(GLIB_SUPPORT)
> >+#include <glib.h>
> >+#endif
> > #endif
> > 
> 
> I said in previous comment that the #ifs are not necessary.
> 
> The rest of the patch looks ok to me!

I modify above code as below,

 31 #elif PLATFORM(EFL)
 32 #if ENABLE(GLIB_SUPPORT)
 33 #include <glib.h>
 34 #endif
 35 #include "Widget.h"
 36 typedef PlatformWidget PlatformWindowType;
 37 #endif

Is this ok ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.