[Webkit-unassigned] [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44508





--- Comment #9 from Philippe Normand <pnormand at igalia.com>  2010-08-25 00:55:49 PST ---
(From update of attachment 65381)
>--- a/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
>+++ b/WebCore/platform/graphics/gstreamer/PlatformVideoWindow.h
>@@ -28,6 +28,15 @@
> #if PLATFORM(GTK)
> #include <gtk/gtk.h>
> typedef GtkWidget PlatformWindowType;
>+#elif PLATFORM(EFL)
>+#include "Widget.h"
>+typedef PlatformWidget PlatformWindowType;
>+#endif
>+

Oh nice I didn't know about Widget.h
So we duplicated efforts here. I think it'd make sense to remove PlatformWindowType and use PlatformWidget directly.

>+#if PLATFORM(EFL)
>+#if ENABLE(GLIB_SUPPORT)
>+#include <glib.h>
>+#endif
> #endif
> 

I said in previous comment that the #ifs are not necessary.

The rest of the patch looks ok to me!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.