[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41842





--- Comment #12 from Dirk Pranke <dpranke at chromium.org>  2010-08-06 14:11:13 PST ---
(In reply to comment #10)
> (From update of attachment 61033 [details])
> With this implemented, we can also now remove some hacks in:
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py#L220
> 
> Yeah, this is not the right layer.
> 
> Some platform-specific function should do the symbol search and return an array of symbols. Then webkit.py should do the lookup in the list of conversions.
> 
> The ports don't really have to do anything.  Except right now port and platform abstractions are mashed totether, so the port will ahve to act as the platform here, and do the search.
> 
> I would just implement this all in webkit.py, except for the library path lookup of course.
> 
> This is close, but not quite right.
>

Eric, I'm not sure I agree with (or at least understand) you here. This list of directories to skip can vary by both platform and port (webkit mac vs. webkit win, webkit win vs. chromium win), and the mechanism for figuring out the presence of a given feature can vary by either mechanism as well. So I'm not sure what you mean by "the ports don't really have to do anything"?

> Also, this needs unit tests.

This is probably true :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.