[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 14:07:19 PDT 2010


--- Comment #11 from Dirk Pranke <dpranke at chromium.org>  2010-08-06 14:07:18 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 61033 [details] [details])
> > Maybe I'm missing something, but I still don't think you need the copy on line 241 of webkit.py. There's no case where you would want to delete the directories from skipped_directories and then add them back in, and so there's no point in looking at the keys in directories_for_symbol over and over again if you've deleted them. There's no correctness issue, but it's unnecessary (and slower).
> > 
> > Otherwise, LGTM (but I'm not a reviewer).
> Without of this .copy() the python throws this:
> File "WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py", line 241, in directories_to_skip
>     for feature_symbol in directories_for_symbol:
> RuntimeError: dictionary changed size during iteration

Ah, right, you're mutating the list while iterating over it. My mistake :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list