[Webkit-unassigned] [Bug 41842] Add feature detection support for NRWT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 6 13:49:04 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41842


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61033|review?                     |review-
               Flag|                            |




--- Comment #10 from Eric Seidel <eric at webkit.org>  2010-08-06 13:49:03 PST ---
(From update of attachment 61033)
With this implemented, we can also now remove some hacks in:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/webkit.py#L220

Yeah, this is not the right layer.

Some platform-specific function should do the symbol search and return an array of symbols. Then webkit.py should do the lookup in the list of conversions.

The ports don't really have to do anything.  Except right now port and platform abstractions are mashed totether, so the port will ahve to act as the platform here, and do the search.

I would just implement this all in webkit.py, except for the library path lookup of course.

This is close, but not quite right.

Also, this needs unit tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list