[Webkit-unassigned] [Bug 37790] [DRT/Chromium] Import Chromium image_diff as ImageDiff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 15:21:35 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37790





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2010-04-19 15:21:33 PST ---
(In reply to comment #4)
> In https://bugs.webkit.org/show_bug.cgi?id=37645#c4 , Dirk suggested having a
> single ImageDiff.  Looking at this more closely, I'm not sure what that means
> :)
> 
> There's currently an ImageDiff CG and an ImageDiff QT which don't share any
> code.  I guess we have to add an ImageDiff for chromium, but I doubt there's
> any code to share.
> 

The point was performing an image diff is really a function of the platform
run-webkit-tests is executing on, rather than the port being tested. There's no
reason to have two different binaries and code bases on a Mac (or Linux or
Windows for that matter).

I think we should just get rid of --tolerance; doing pixel tests that aren't
exact seems like a bad idea to me.

-- Dirk

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list