[Webkit-unassigned] [Bug 37790] [DRT/Chromium] Import Chromium image_diff as ImageDiff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37790


Tony Chang (Google) <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org,
                   |                            |eseidel at chromium.org,
                   |                            |tony at chromium.org




--- Comment #4 from Tony Chang (Google) <tony at chromium.org>  2010-04-19 02:23:31 PST ---
In https://bugs.webkit.org/show_bug.cgi?id=37645#c4 , Dirk suggested having a
single ImageDiff.  Looking at this more closely, I'm not sure what that means
:)

There's currently an ImageDiff CG and an ImageDiff QT which don't share any
code.  I guess we have to add an ImageDiff for chromium, but I doubt there's
any code to share.

A few questions:

- What is the difference between compareImages and untestedCompareImages? 
Should we try to switch to untestedCompareImages so we can be more like the
existing ImageDiffs?

- Also, should we add --tolerance as a command line flag like the others?

- I guess we have to include gfx for the pngencoder, I guess that's ok.  Can we
avoid base/basictypes.h?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.