[Webkit-unassigned] [Bug 37790] [DRT/Chromium] Import Chromium image_diff as ImageDiff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37790





--- Comment #6 from Tony Chang (Google) <tony at chromium.org>  2010-04-19 16:48:41 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > There's currently an ImageDiff CG and an ImageDiff QT which don't share any
> > code.  I guess we have to add an ImageDiff for chromium, but I doubt there's
> > any code to share.
> 
> The point was performing an image diff is really a function of the platform
> run-webkit-tests is executing on, rather than the port being tested. There's no
> reason to have two different binaries and code bases on a Mac (or Linux or
> Windows for that matter).

We could use the existing ImageDiff CG on mac, since all the dependencies are
the same, but on Windows and Linux we would still need our own ImageDiff.  I
think adding another one is fine, although it's a little unfortunate that it'll
be Chromium specific because it uses files from gfx and depends on libpng.

> I think we should just get rid of --tolerance; doing pixel tests that aren't
> exact seems like a bad idea to me.

That seems like a separate discussion.  Please file a new bug for it.  For now,
we should probably try to match the existing behavior of ImageDiff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.