[Webkit-unassigned] [Bug 37477] check-webkit-style isn't enforcing 80-column limits in python files for PEP-8 compliance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37477


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hamaji at chromium.org,
                   |                            |levin at chromium.org




--- Comment #7 from Dirk Pranke <dpranke at chromium.org>  2010-04-14 12:13:43 PST ---
The comments in bug 33639 talk about turning this feature off until the rest of
the code is brought into compliance. As this bug indicates, that'll never
happen - the people who don't use 80 columns by default will do what they're
used to and more code will fail to comply, not less.

I also believe that the people who care about there being any real limit on
line width only care about 80 columns (i.e., if you make the limit 81 or 82,
let alone 120, you'll still piss people off). 

As Adam commented in 33639, the issue of Python style compliance had been
discussed before on the broader and more appropriately place (webkit-dev). See
https://lists.webkit.org/pipermail/webkit-dev/2010-January/011423.html

It seems inappropriate that would would make this decision and change it in a
patch that didn't get wider discussion or review. Can we make this decision
once and for all (yeah right) on webkit-dev and then document it in the WebKit
style guidelines so that enough people can weigh in and we can get a definitive
record? If the majority of people that care think we should change it, then by
all means, change it, but don't just do it on the sly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.