[Webkit-unassigned] [Bug 37477] check-webkit-style isn't enforcing 80-column limits in python files for PEP-8 compliance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37477





--- Comment #6 from Chris Jerdonek <cjerdonek at webkit.org>  2010-04-14 11:31:20 PST ---
(In reply to comment #2)
> (In reply to comment #0)
> > My understanding is that we're trying to stay within 80-column files for strict
> > PEP-8 compliance, but for some reason check-webkit-style isn't enforcing this.
> > 
> > Which is odd, since I think the pep8 script that we're using does this by
> > default. Did we tweak a setting for some reason, or are we not trying to follow
> > this?
> 
> That change is something Eric wanted.  At the moment I can't find the bug
> report where we discussed it, but the code change is here:
> 
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/style/checker.py?rev=57467#L94

FYI, the discussion around not enforcing the 79-character limit took place
here:

https://bugs.webkit.org/show_bug.cgi?id=33639#c30

I think we are still open to enforcing that or some longer limit, but Eric
preferred that existing lines be fixed before we discuss reimposing a limit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.