[Webkit-unassigned] [Bug 27376] [WINCE] Add WinCE specific files for platform/network

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27376


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33206|review?                     |review-
               Flag|                            |




--- Comment #12 from Adam Barth <abarth at webkit.org>  2009-09-01 17:53:05 PDT ---
(From update of attachment 33206)
+ #ifndef AuthenticationChallenge_h

Missing space before this line.

+ #if PLATFORM(TORCHMOBILE)

Is TORCHMOBILE really a platform?  I would have expected WINCE here.

+ static ThreadData g_threadData = {0};

No real point in declaring this static inside the anonymous namespace...

+ } // namespace WebCore

Missing space before this line.

+ punycode.c

It's unclear to me whether this license is compatible with the BSD license
because the BSD license does diminish someone's ability to distribute: they
must include the license block.  I can't R+ this patch without input from a
lawyer.

Also, this file isn't even close to WebKit style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.