[Webkit-unassigned] [Bug 27376] [WINCE] Add WinCE specific files for platform/network

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27376





--- Comment #13 from Yong Li <yong.li at torchmobile.com>  2009-09-01 18:02:43 PDT ---
(In reply to comment #12)
> (From update of attachment 33206 [details])
> + #ifndef AuthenticationChallenge_h
> 
> Missing space before this line.
> 
> + #if PLATFORM(TORCHMOBILE)
> 
> Is TORCHMOBILE really a platform?  I would have expected WINCE here.
> 
The file is for WINCE only. I will change it to #if ENABLE(SINGLE_THREADED)

> + static ThreadData g_threadData = {0};
> 
> No real point in declaring this static inside the anonymous namespace...

In case ThreadData conflicts with WTF::ThreadData.

> 
> + } // namespace WebCore
> 
> Missing space before this line.
> 
> + punycode.c
> 
> It's unclear to me whether this license is compatible with the BSD license
> because the BSD license does diminish someone's ability to distribute: they
> must include the license block.  I can't R+ this patch without input from a
> lawyer.
> 
> Also, this file isn't even close to WebKit style.

k. will move the file out of there

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.