[Webkit-unassigned] [Bug 27376] [WINCE] Add WinCE specific files for platform/network

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27376


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33204|review?                     |review-
               Flag|                            |




--- Comment #11 from Adam Barth <abarth at webkit.org>  2009-09-01 17:42:36 PDT ---
(From update of attachment 33204)
One class per file, please.

+  static ResourceJobManager jm;

You should use the DEFINE_STATIC_LOCAL macro.

+ ConnectionManager() //, LPCWSTR userAgentTex)

Please don't included commented out code.

+ delete m_connMgr;
delete[] m_formDataString;

Why not OwnPtr and OwnArray?

+ ResourceHandle::setResponse

The fake URL parsing in this function is not cool.  Also, this primitive mime
sniffing is very insecure.

I stopped reviewing this patch at this point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.