[Webkit-unassigned] [Bug 30220] [GTK] middle-click-onpaste.html test does not work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 11:23:37 PDT 2009


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #40893|review-                     |review+, commit-queue+
               Flag|                            |

--- Comment #11 from Xan Lopez <xan.lopez at gmail.com>  2009-10-08 11:23:37 PDT ---
(From update of attachment 40893)
I disagree with Eric.

The code already uses g_return_val_if_fail everywhere, so if we were to change
it we should do it all at once. Besides, I don't think it makes any sense to
let DRT do stupid things (or crash) when you already know the input is wrong.
This is what g_return_* is for.

In any case the logic in these checks is wrong, so we are going to do another
patch to change them all at once.

I'm going to r+ this now so we can pass the tests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list