[Webkit-unassigned] [Bug 30220] [GTK] middle-click-onpaste.html test does not work
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 8 11:14:47 PDT 2009
https://bugs.webkit.org/show_bug.cgi?id=30220
Eric Seidel <eric at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #40893|review? |review-
Flag| |
--- Comment #10 from Eric Seidel <eric at webkit.org> 2009-10-08 11:14:47 PDT ---
(From update of attachment 40893)
Personally I don't find g_return_val_if_fail very readable.
if (!exception || !*exception)
return JSValueMakeUndefined(context);
is the same number of characters, split over 2 lines, and much more readable to
those of us who don't hack on gtk normally. :)
Also, I think that this should just assert(!exception) instead. The testing
tool is allowed to fail hard in cases like this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list