[Webkit-unassigned] [Bug 30220] [GTK] middle-click-onpaste.html test does not work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 8 11:27:20 PDT 2009


--- Comment #12 from Alejandro Garcia Castro <alex at igalia.com>  2009-10-08 11:27:20 PDT ---
(In reply to comment #10)
> (From update of attachment 40893 [details])
> Personally I don't find g_return_val_if_fail very readable.
> if (!exception || !*exception)
>     return JSValueMakeUndefined(context);
> is the same number of characters, split over 2 lines, and much more readable to
> those of us who don't hack on gtk normally. :)

Well, I'm not the one deciding about using or not the return if fail, they are
all over the code, maybe you should open a bug to discuss this.

> Also, I think that this should just assert(!exception) instead.  The testing
> tool is allowed to fail hard in cases like this.

I agree with you here :), I copied the tests that were done in all this code
for the exceptions and they do not look right. I'll upload a new bug to change
all the checks for once.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list