[Webkit-unassigned] [Bug 26354] [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26354





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2009-11-24 04:01:07 PST ---
(In reply to comment #9)
> (From update of attachment 43757 [details])
> Good. Do you need someone to commit this, or you have commit privileges by now?
> 

Received the invitation today, might take some time for the paper work to be
done ;)

> Some nits:
> 
>  163     bool available = false;
>  164     GstElementFactory* factory;
>  165 
>  166     do_gst_init();
>  167     factory = gst_element_factory_find("playbin2");
> 
> factory should only be declared here, where it is first used. Perhaps you can
> also lose the available variable, and just return true inside the if (factory)
> check, returning false otherwise.

I used a factory variable because the return value of gst_element_factory_find
needs to be unreffed after use.

Do you want me to send a new patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.