[Webkit-unassigned] [Bug 26354] [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26354


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43757|review?                     |review+
               Flag|                            |




--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2009-11-24 03:52:18 PST ---
(From update of attachment 43757)
Good. Do you need someone to commit this, or you have commit privileges by now?

Some nits:

 163     bool available = false;
 164     GstElementFactory* factory;
 165 
 166     do_gst_init();
 167     factory = gst_element_factory_find("playbin2");

factory should only be declared here, where it is first used. Perhaps you can
also lose the available variable, and just return true inside the if (factory)
check, returning false otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.