[Webkit-unassigned] [Bug 26354] [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26354





--- Comment #11 from Gustavo Noronha (kov) <gns at gnome.org>  2009-11-24 04:05:27 PST ---
(In reply to comment #10)

> > Some nits:
> > 
> >  163     bool available = false;
> >  164     GstElementFactory* factory;
> >  165 
> >  166     do_gst_init();
> >  167     factory = gst_element_factory_find("playbin2");
> > 
> > factory should only be declared here, where it is first used. Perhaps you can
> > also lose the available variable, and just return true inside the if (factory)
> > check, returning false otherwise.
> 
> I used a factory variable because the return value of gst_element_factory_find
> needs to be unreffed after use.

Yeah. You do need factory. What you could do to it is use GOwnPtr.

The variable I say you should lose is 'bool available'. You can just return
true inside the if that checks for factory.

If you can't commit, then yeah, please upload a new patch =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.