[Webkit-unassigned] [Bug 31475] Crash in StringHash::equal due to unaligned string data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31475


Yong Li <yong.li.webkit at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |staikos at kde.org




--- Comment #2 from Yong Li <yong.li.webkit at gmail.com>  2009-11-13 12:27:49 PST ---
(In reply to comment #1)
> > The solution that Dave Tapuska suggests is: When UString::data() is not aligned
> > to 4-byte, we just don't use the shared buffer.
> > 
> > Anyone please give some comments?
> 
> Tricky. I created this bug unfortunately.
> 
> I can see at least two solutions:
> 1. Dave Tapuska;s suggestion.
> 2. Change StringHash::Equal to use memcmp
> 
> You could try each solution separately in a ship build and run drameo and see
> which has less of a perf impact. 
> 
> I suspect that #1 is the better option.

Yeah, that's what we tried, and either way can fix the problem. But we haven't
run any performance test so far. BTW, the performance affect may rely on
platform/compiler. memcmp (or wmemcmp?) could probably be optimized with some
inline code by compiler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.