[Webkit-unassigned] [Bug 31475] Crash in StringHash::equal due to unaligned string data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 12:54:38 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31475





--- Comment #3 from Darin Adler <darin at apple.com>  2009-11-13 12:54:36 PST ---
It's easy to make an alternate StringHash::equal in a way that does not depend
on type punning in a non-portable way. The performance  optimization of
comparing four bytes at a time is not needed just to have WebKit. So I suggest
starting by changing StringHash::equal to only do the optimization on platforms
where it is safe.

The other question, though, is whether the unaligned strings are having some
sort of performance cost on platforms where the optimization is safe.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list