[Webkit-unassigned] [Bug 31475] Crash in StringHash::equal due to unaligned string data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31475


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |levin at chromium.org




--- Comment #1 from David Levin <levin at chromium.org>  2009-11-13 12:20:48 PST ---
> The solution that Dave Tapuska suggests is: When UString::data() is not aligned
> to 4-byte, we just don't use the shared buffer.
> 
> Anyone please give some comments?

Tricky. I created this bug unfortunately.

I can see at least two solutions:
1. Dave Tapuska;s suggestion.
2. Change StringHash::Equal to use memcmp

You could try each solution separately in a ship build and run drameo and see
which has less of a perf impact. 

I suspect that #1 is the better option.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.