[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #23 from Yong Li <yong.li at torchmobile.com>  2009-07-30 14:40:45 PDT ---
(In reply to comment #22)
> (In reply to comment #21)
> > (In reply to comment #20)

> > 
> > Do you mean RGBA32Buffer? Don't want to mess it up. Also, I think RGBA32Buffer
> > should be extracted to a separate header.
> 
> Yes, the RGBA32Buffer inside ImageDecoder.h.
> 
> I agree that eventually it should be moved into its own place, but for now it's
> not there, and it's hard to remember that the WinCE port happens to have a
> completely differently-named implementation living off in a separate place. 
> When I make changes to the cross-platform version, I'll likely break your
> build.
> 

OK. I'll make it shared code with RGBA32Buffer. But, this bug is supposed to
only contain new files. The changes in ImageDecoder.h will go to another bug.
To reduce the naming change, I'll "typedef RGBA32Buffer ImageFrameSink;", what
do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.