[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #22 from Peter Kasting <pkasting at google.com>  2009-07-30 13:58:41 PDT ---
(In reply to comment #21)
> (In reply to comment #20)
> > Your first patch contains a ChangeLog listing all the files you've changed in
> > total, and your other patches don't have any ChangeLogs.
> 
> I split them for easier review. Hope they can be committed at one time.

It would be easier for reviewers and anyone landing the patch if each patch was
self-contained...

> > ImageFrameSink is basically a copy of the cross-platform ImageDecoder with one
> > or two small changes.  Would it be better to write this as a patch to
> > ImageDecoder?
> > 
> 
> Do you mean RGBA32Buffer? Don't want to mess it up. Also, I think RGBA32Buffer
> should be extracted to a separate header.

Yes, the RGBA32Buffer inside ImageDecoder.h.

I agree that eventually it should be moved into its own place, but for now it's
not there, and it's hard to remember that the WinCE port happens to have a
completely differently-named implementation living off in a separate place. 
When I make changes to the cross-platform version, I'll likely break your
build.

> > Some of your files have vim formatting comments at bottom.  Seems like these
> > should be stripped.
> 
> what's that?

I guess it's only ImageSourceWince.cpp.  "// vim: ts=4 sw=4 et" at bottom.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.