[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #24 from Peter Kasting <pkasting at google.com>  2009-07-30 14:54:14 PDT ---
(In reply to comment #23)
> OK. I'll make it shared code with RGBA32Buffer. But, this bug is supposed to
> only contain new files. The changes in ImageDecoder.h will go to another bug.
> To reduce the naming change, I'll "typedef RGBA32Buffer ImageFrameSink;", what
> do you think?

Hmm... I'm trying to figure out what the best landing sequence here is, since
those ImageDecoder changes might take a while to work through.

Seems like there are a lot of options:

* Land ImageFrameSink as-is, in graphics/wince.  Perhaps add comments atop
ImageDecoder.h/ImageFrameSink.h noting the similarities between the two, in
hopes that people won't break your port.  File a new bug about merging the two
together.

* Break RGBA32Buffer out of ImageDecoder.h into its own header, but don't
change anything else about it.  Put your versions alongside this
header/implementation.  Not sure what the names of each should be at that
point.  Hope that this provides enough motivation for people to combine the two
eventually.

* Wait until RGBA32Buffer gets pulled out of ImageDecoder and moved over to
graphics/.  Modify RGBA32Buffer directly, and rename it something more
accurate.  (Although TBH I despise the name "ImageFrameSink" as it feels
somewhere between meaningless and inaccurate.  Just "ImageFrame" would probably
be better.)

* Various other combinations of the above

It doesn't seem fair to either force you to refactor all the image classes or
make you wait on somebody else to do it (although it would be nice to have help
refactoring things...).  Perhaps the first option is the best thing for the
WinCE port.  Even though I suggested modifying RGBA32Buffer, I have the feeling
it's going to take some time and effort to examine the changes you've made and
figure out how to best merge them in to the code everyone else is using
(hopefully with few if any #ifdefs).  So maybe a strategy that gets your files
into the tree is better...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.