[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #21 from Yong Li <yong.li at torchmobile.com>  2009-07-30 13:45:29 PDT ---
(In reply to comment #20)
> Your first patch contains a ChangeLog listing all the files you've changed in
> total, and your other patches don't have any ChangeLogs.

I split them for easier review. Hope they can be committed at one time.

> 
> ImageFrameSink is basically a copy of the cross-platform ImageDecoder with one
> or two small changes.  Would it be better to write this as a patch to
> ImageDecoder?
> 

Do you mean RGBA32Buffer? Don't want to mess it up. Also, I think RGBA32Buffer
should be extracted to a separate header.

Hm... just found a problem there: setRGBA there is actuallly set to ARGB.
(32bit Bitmap is ARGB by default on windows)

> Your implementation of BitmapImage::draw() is incorrect.  StartAnimation()
> needs to be called before drawing, not after.  Seems like maybe you wrote this
> implementation a year or two ago.  You might want to go study how the CG or
> Skia implementations have been modified since then.

You're right. Thanks.

> 
> Some of your files have vim formatting comments at bottom.  Seems like these
> should be stripped.

what's that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.