[Webkit-unassigned] [Bug 27511] Add WinCE specific platform/graphics files to WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 30 13:24:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27511





--- Comment #20 from Peter Kasting <pkasting at google.com>  2009-07-30 13:24:21 PDT ---
Your first patch contains a ChangeLog listing all the files you've changed in
total, and your other patches don't have any ChangeLogs.

ImageFrameSink is basically a copy of the cross-platform ImageDecoder with one
or two small changes.  Would it be better to write this as a patch to
ImageDecoder?

Your implementation of BitmapImage::draw() is incorrect.  StartAnimation()
needs to be called before drawing, not after.  Seems like maybe you wrote this
implementation a year or two ago.  You might want to go study how the CG or
Skia implementations have been modified since then.

Some of your files have vim formatting comments at bottom.  Seems like these
should be stripped.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list