[Webkit-unassigned] [Bug 27603] updating Document.idl to match HTML5 spec: domain read-write and access to getSelection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27603





--- Comment #3 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-23 15:06:36 PDT ---
(In reply to comment #2)
> (From update of attachment 33323 [details])
> >  #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> >                   attribute [ConvertNullToNullString] DOMString domain;
> >  #else
> > -        readonly attribute DOMString domain;
> > +        attribute DOMString domain;
> >  #endif
> 
> It doesn't seem necessary to have this be #if'd any more.

 ah... oh?  oh, what, because the [ConvertNullToNullString] gets ignored by
bindings generators that don't need it?  oh, ok.  great.  less code!

> > +        // now in HTML5 specification
> > +        DOMSelection       getSelection();
> 
> The comment doesn't add anything.

 oh, ok.  just trying to be helpful.

> > +2009-07-22  lkcl <lkcl at lkcl.net>
> > +
> > +        Reviewed by NOBODY (OOPS!)
> > +
> > +        https://bugs.webkit.org/show_bug.cgi?id=27603
> > +
> > +		https://bugs.webkit.org/show_bug.cgi?id=27434#c3 suggests that the
> > +		domain property be made read-write and that access to getSelection be
> > +		made universal to all bindings, to match the HTML5 specification.
> > +
> > +        * dom/Document.idl: updated to match HTML spec on domain and getSelection
> 
> Your ChangeLog entry again contains tabs that will make our pre-commit hook
> unhappy.

 achhh, yes, that's vi messing up (ok - me messing up using vi) sorry.  now i
know, i've done s/^I/    /g but there may be a couple of entries still with
tabs, i'll try to find them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.