[Webkit-unassigned] [Bug 27603] updating Document.idl to match HTML5 spec: domain read-write and access to getSelection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 23 09:50:53 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27603





--- Comment #2 from Mark Rowe (bdash) <mrowe at apple.com>  2009-07-23 09:50:53 PDT ---
(From update of attachment 33323)
>  #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
>                   attribute [ConvertNullToNullString] DOMString domain;
>  #else
> -        readonly attribute DOMString domain;
> +        attribute DOMString domain;
>  #endif

It doesn't seem necessary to have this be #if'd any more.

> +        // now in HTML5 specification
> +        DOMSelection       getSelection();

The comment doesn't add anything.

> +2009-07-22  lkcl <lkcl at lkcl.net>
> +
> +        Reviewed by NOBODY (OOPS!)
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=27603
> +
> +		https://bugs.webkit.org/show_bug.cgi?id=27434#c3 suggests that the
> +		domain property be made read-write and that access to getSelection be
> +		made universal to all bindings, to match the HTML5 specification.
> +
> +        * dom/Document.idl: updated to match HTML spec on domain and getSelection

Your ChangeLog entry again contains tabs that will make our pre-commit hook
unhappy.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list