[Webkit-unassigned] [Bug 27603] updating Document.idl to match HTML5 spec: domain read-write and access to getSelection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27603





--- Comment #4 from Luke Kenneth Casson Leighton <lkcl at lkcl.net>  2009-07-23 15:14:02 PDT ---
> > +        // now in HTML5 specification
> > +        DOMSelection       getSelection();
> 
> The comment doesn't add anything.

 ahh, yes it does.  look carefully at the original file, and you
 can see that getSelection() _used_ to be commented
 as a "Mozilla Extension".

 if you remove only the #ifdef, and don't provide a comment,
 it looks like getSelection() is an IE Extension (not an
 HTML5ism) because that's the commented-block above it.


        // IE extensions

                 attribute [ConvertNullStringTo=Undefined,
ConvertNullToNullString] DOMString charset;
        readonly attribute [ConvertNullStringTo=Undefined] DOMString
defaultCharset;
        readonly attribute [ConvertNullStringTo=Undefined] DOMString
readyState;

        Element            elementFromPoint(in long x, in long y);

        // HTML 5
        DOMSelection       getSelection();

        // Mozilla extensions

        readonly attribute [ConvertNullStringTo=Null] DOMString characterSet;


 looking _further_ down the Document.idl file, you can see
 that there is in fact a comment "// HTML 5" already in there:

        // HTML 5
        NodeList getElementsByClassName(in DOMString tagname);


 so, anticipating that "HTML 5" is acceptable, because it's already
 _in_ the file, i'm resubmitting a patch which contains the exact
 same comment "HTML 5".

 the alternative is to move the function getSelection() to somewhere
 which would only confuse people.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.