[Webkit-unassigned] [Bug 27171] [Gtk] REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 13 03:12:21 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=27171


Jan Alonzo <jmalonzo at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Jan Alonzo <jmalonzo at gmail.com>  2009-07-13 03:12:21 PDT ---
(In reply to comment #2)
> (From update of attachment 32605 [details])
> > -        core(webView)->focusController()->setActive(frame);
> > -        core(webView)->focusController()->setFocused(true);
> > +        focusController->setActive(true);
> > +        focusController->setFocused(true);
> 
> The only change that makes me a bit nervous is going from frame to true here. I
> believe there might have been a reason to not set it unconditionally? r=me, but
> please either revert this specific change, or add a comment here on the bug so
> that we have a way of tracking this down.

Thanks. I reverted the change and landed it in
http://trac.webkit.org/changeset/45802.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list