[Webkit-unassigned] [Bug 27171] [Gtk] REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27171


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32605|review?                     |review+
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2009-07-12 04:40:57 PDT ---
(From update of attachment 32605)
> -        core(webView)->focusController()->setActive(frame);
> -        core(webView)->focusController()->setFocused(true);
> +        focusController->setActive(true);
> +        focusController->setFocused(true);

The only change that makes me a bit nervous is going from frame to true here. I
believe there might have been a reason to not set it unconditionally? r=me, but
please either revert this specific change, or add a comment here on the bug so
that we have a way of tracking this down.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.