[Webkit-unassigned] [Bug 27172] New: bugzilla-tool: create CommitMessage class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27172

           Summary: bugzilla-tool: create CommitMessage class
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: eric at webkit.org, levin at chromium.org



David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32604|                            |review?
               Flag|                            |


Created an attachment (id=32604)
 --> (https://bugs.webkit.org/attachment.cgi?id=32604)
Patch v1

Reviewed by NOBODY (OOPS!).

Create a CommitMessage class to encapsulate related code.

* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Moved to
CommitMessage.parse_bug_id().
(commit_message_for_this_commit): Return a CommitMessage.
(ApplyPatchesFromBug.apply_patches): Use CommitMessage.message().
(LandPatchesFromBugs.build_and_commit): Ditto.
(CommitMessageForCurrentDiff.execute): Ditto.
(PostCommitsAsPatchesToBug.execute): Switched from
Git.commit_message_for_commit() to
Git.commit_message_for_local_commit().  Switched from
bug_id_from_commit_message() to CommitMessage.parse_bug_id().

* Scripts/modules/scm.py:
(first_non_empty_line_after_index): Added.
(CommitMessage.__init__): Added.
(CommitMessage.body): Added.
(CommitMessage.description): Added.
(CommitMessage.message): Added.
(CommitMessage.parse_bug_id): Added.  Moved from
bug_id_from_commit_message() in bugzilla-tool.
(Git.commit_message_for_local_commit): Renamed from
commit_message_for_commit().  Return a CommitMessage.
---
 3 files changed, 87 insertions(+), 21 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.