[Webkit-unassigned] [Bug 23147] Introduce Skia to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23147


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26494|review?                     |review-
               Flag|                            |




------- Comment #15 from eric at webkit.org  2009-01-07 13:30 PDT -------
(From update of attachment 26494)
0 is the WebKit way:
+    , m_platformContext(NULL)  // Canvas is set in ImageBuffer constructor.

Not needed in Webkit Style:
+    : m_canvas()

Wow, strange to have a success parameter on a constructor.

Best line ever:
+    unsigned char* data = result->data()->data().data();

I think WebKit style would have these be true camelCase instead of lowercase:
+    int originx = rect.x();
+    int destx = 0;
originX, destX

Style:
+    if (srcWidth == destIWidth && srcHeight == destIHeight) {
+        // We don't need to resample if the source and destination are the
same.
+        return RESAMPLE_NONE;
+    }

Style:
+                         float src_width,
+                         float src_height,
+                         float* dest_width,
+                         float* dest_height) {

I thought gfx:: was off-limits from WebCore code?
+        gfx::Rect destBitmapSubset(destBitmapSubsetSkI.fLeft,

Style:
+    else {
+      resampling = computeResamplingMode(*bitmap,
+                                         srcRect.width(), srcRect.height(),
+                                         dest_bitmap_width,
dest_bitmap_height);
+    }

We should probably write out "bitmap" or "skImage" here:
+    const NativeImageSkia* bm = nativeImageForCurrentFrame();
+    if (!bm)
+        return;  // It's too early and we don't have an image yet.

Spacing:
+ImageSource::ImageSource()
+  : m_decoder(0)
+{}

Nope:
+#define private protected
+#include "ImageSource.h"
That needs to be fixed before landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.