[Webkit-unassigned] [Bug 23147] Introduce Skia to WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23147





------- Comment #16 from eric at webkit.org  2009-01-07 13:47 PDT -------
(From update of attachment 26493)
3 #include "wtf/MathExtras.h"
should be <wtf/MathExtras.h>

I hate these:
+#ifdef CHECK_REASONABLE
Sigh.  I know they're necessary for now.

+    if (fillColor().rgb() & 0xFF000000) {:
I prefer somthing like fillColor().hasAlpha() personally.  Or in this case I
think it's making sure it's non-transparent.  There is more than one of these.

Style:
+    SkRegion exterior_region;
+    const SkScalar exterior_offset = WebCoreFloatToSkScalar(0.5);

Style:
+    static SkBitmap* misspell_bitmap = 0;

(several in that function)

This is not needed:
+    paint.setColor(this->strokeColor().rgb());


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.