[Webkit-unassigned] [Bug 32989] [Qt] DRT: Frame loader callbacks differ from the Mac port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32989





--- Comment #4 from Jakub Wieczorek <faw217 at gmail.com>  2009-12-28 12:47:08 PST ---
(In reply to comment #3)
> jakub, although "proposed patch" gets good results (many tests can be
> unskipped), I did not like the solution very much, mainly because these
> messages you are removing are useful for debugging.

I understand the point about having these messages for the sake of debugging
but should they prevent the Qt port from passing loader tests against the
cross-platform expected results?

Do you think it would be fine to leave those messages commented out?

> A better solution would be stop calling "qt_dump_frame_loader" (see quoted code
> below), imo.
> 
> void DumpRenderTree::open(const QUrl& aurl)
> {
>     (...)
>     qt_dump_frame_loader(url.toString().contains("loading/"));
>     setTextOutputEnabled(true);
>     m_page->mainFrame()->load(url);
> }
> 
> 
> please consider this as well ...

I'm sorry, I didn't get this. Can you elaborate a bit more please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.