[Webkit-unassigned] [Bug 32989] [Qt] DRT: Frame loader callbacks differ from the Mac port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32989


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |tonikitoo at webkit.org
     Ever Confirmed|0                           |1




--- Comment #3 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2009-12-28 12:32:19 PST ---
jakub, although "proposed patch" gets good results (many tests can be
unskipped), I did not like the solution very much, mainly because these
messages you are removing are useful for debugging.

A better solution would be stop calling "qt_dump_frame_loader" (see quoted code
below), imo.

void DumpRenderTree::open(const QUrl& aurl)
{
    (...)
    qt_dump_frame_loader(url.toString().contains("loading/"));
    setTextOutputEnabled(true);
    m_page->mainFrame()->load(url);
}


please consider this as well ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.