[Webkit-unassigned] [Bug 32989] [Qt] DRT: Frame loader callbacks differ from the Mac port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32989





--- Comment #5 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2009-12-28 12:56:21 PST ---

> I'm sorry, I didn't get this. Can you elaborate a bit more please?

by looking at the messages, they are mostly enclosed by an "if". e.g.:

void FrameLoaderClientQt::dispatchDidHandleOnloadEvents()
{
    // don't need this one
    if (dumpFrameLoaderCallbacks)
        printf("%s - didHandleOnloadEventsForFrame\n",
qPrintable(drtDescriptionSuitableForTestResult(m_frame)));
}


"dumpFrameLoaderCallbacks" is a global var exported to DRT via "extern".

Now in the DumpRenderThree::open code formely quoted, see
"qt_dump_frame_loader" method call specifically. It is the method that enables
dumping these debug message you want to remove. So another option would instead
of removing all the messages from the code, we could just stop calling
"qt_dump_frame_loader" at DumpRenderThree::open, then they would not dump and
debuggers would still be happy :)

make more sense now ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.