[Webkit-unassigned] [Bug 32698] [JSC] Date binding support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32698


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #4 from TAMURA, Kent <tkent at chromium.org>  2009-12-18 09:52:40 PST ---
(In reply to comment #3)
> This isn't right. We can't just call toObject and then cast to DateInstance*
> without some sort of type check. I also suggest considering putting this logic
> into a function in JSDOMBinding.h and just have the generated code call the
> function instead of putting the logic into the bindings generator.

Ok, I'll update the patch.

> I think the patch needs to include one use of this binding so we can implement
> the test cases we'll need.

As you can guess, I'm implementing HTMLInputElement::valueAsDate.  It will have
code which is more complex than this patch. Is it ok to implement valueAsDate()
and setValueAsDate() as just placeholder functions?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.