[Webkit-unassigned] [Bug 32698] [JSC] Date binding support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32698


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45128|0                           |1
        is obsolete|                            |
  Attachment #45166|                            |review?, commit-queue-
               Flag|                            |




--- Comment #5 from TAMURA, Kent <tkent at chromium.org>  2009-12-18 12:02:14 PST ---
Created an attachment (id=45166)
 --> (https://bugs.webkit.org/attachment.cgi?id=45166)
Proposed patch (rev.2)

* Follow the Darin's comments.

Produced code will be:

JSValue jsHTMLInputElementValueAsDate(ExecState* exec, const Identifier&, const
PropertySlot& slot)
{
    JSHTMLInputElement* castedThis =
static_cast<JSHTMLInputElement*>(asObject(slot.slotBase()));
    UNUSED_PARAM(exec);
    HTMLInputElement* imp = static_cast<HTMLInputElement*>(castedThis->impl());
    return jsDateOrNull(exec, imp->valueAsDate());
}


void setJSHTMLInputElementValueAsDate(ExecState* exec, JSObject* thisObject,
JSValue value)
{
    HTMLInputElement* imp =
static_cast<HTMLInputElement*>(static_cast<JSHTMLInputElement*>(thisObject)->impl());
    ExceptionCode ec = 0;
    imp->setValueAsDate(valueToDateWithUndefinedOrNullCheck(exec, value), ec);
    setDOMException(exec, ec);
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.