[Webkit-unassigned] [Bug 32698] [JSC] Date binding support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32698


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45128|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2009-12-18 09:33:44 PST ---
(From update of attachment 45128)
> +    return "$value.isUndefinedOrNull() ? std::numeric_limits<double>::quiet_NaN() : static_cast<DateInstance*>($value.toObject(exec))->internalNumber()" if $type eq "Date";

This isn't right. We can't just call toObject and then cast to DateInstance*
without some sort of type check. I also suggest considering putting this logic
into a function in JSDOMBinding.h and just have the generated code call the
function instead of putting the logic into the bindings generator.

I think the patch needs to include one use of this binding so we can implement
the test cases we'll need.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.