[Webkit-unassigned] [Bug 32597] Check one space before end of line comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32597





--- Comment #8 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-16 18:11:56 PST ---
(In reply to comment #6)

> Hmm, so we don't need use_webkit_styles() and should have webkit style defaults
> in _DEFAULT_FILTERS?

You should update since check-webkit-style changed since your patch.

My thinking is that the webkit default filter rules formerly in
use_webkit_styles() should move from cpp_style.py to the check-webkit-style
executable, and they should be passed in as a parameter to a function in
cpp_style.py.  That's the direction I'm moving in:

https://bugs.webkit.org/show_bug.cgi?id=32592

I also think we should phase out the _DEFAULT_FILTERS global variable (now
called _DEFAULT_FILTER_RULES), but we can't do that quite yet since the unit
tests use it if I remember right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.